Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-menu MenuItem visible flag doesn't work on PrimeNG v18 #17204

Closed
1 of 4 tasks
shawnweeks opened this issue Dec 24, 2024 · 2 comments
Closed
1 of 4 tasks

p-menu MenuItem visible flag doesn't work on PrimeNG v18 #17204

shawnweeks opened this issue Dec 24, 2024 · 2 comments
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.2

Comments

@shawnweeks
Copy link

Describe the bug

The p-menu component's MenuItem visible flag doesn't work in PrimeNG 18+. This appears to be due to a missing p-hidden CSS style that was included in previous versions.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-nr4xpl6r-qntkcyjt

Environment

Default StickBlitz environment based on PrimeNG Issue Template

Angular version

18.0.1

PrimeNG version

v18 (LTS Only)

Node version

18.20.3

Browser(s)

No response

Steps to reproduce the behavior

  1. Open Stackblitz link.
  2. Wait for project to start.
  3. Notice Search-Hidden isn't hidden despite visible flag being set to false

Expected behavior

Search-Hidden menu item should be hidden
@shawnweeks shawnweeks added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 24, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 25, 2024
@mertsincan mertsincan added this to the Future milestone Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 25, 2024
@github-actions GitHub Actions
Copy link

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

@vinnyab28 vinnyab28 mentioned this issue Dec 26, 2024
Closed
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Resolution: Help Wanted Issue or pull request requires extra help and feedback labels Dec 26, 2024
@cetincakiroglu cetincakiroglu self-assigned this Dec 26, 2024
@cetincakiroglu cetincakiroglu modified the milestones: Future, 19.0.2 Dec 26, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 26, 2024
@shawnweeks
Copy link
Author

There is actually still a bug here, if the menu item is nested the visible flag is ignored. I've updated the stickblitz example.

@shawnweeks shawnweeks mentioned this issue Dec 30, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.2
Development

No branches or pull requests
3 participants
@shawnweeks @mertsincan @cetincakiroglu