Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: p-picklist #14420

Closed
tsepton opened this issue Dec 21, 2023 · 3 comments
Closed

Component: p-picklist #14420

tsepton opened this issue Dec 21, 2023 · 3 comments
Assignees
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@tsepton
Copy link

tsepton commented Dec 21, 2023

Describe the bug

With the PickList component, using the Input leftButtonAriaLabel to set up the aria label of the 'move to left' button does not work. The value of the Input allLeftButtonAriaLabel is used instead.

Environment

Using VSCode and Angular v17 with the latest version from PrimeNG (17).

Reproducer

No response

Angular version

17.0.7

PrimeNG version

17.1.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

No response

Steps to reproduce the behavior

@Component({
    imports: [
        CommonModule,
        PickListModule,
    ],
    template: '
    <p-pickList
        allLeftButtonAriaLabel="label on all left"
        leftButtonAriaLabel="label on only selected left"
    ></p-pickList>
    '
})
export class ReproducerComponent {}

Expected behavior

Aria label from the button to put a selected element on the left should not have the value given to 'allLeftButtonAriaLabel', instead it should have the value from leftButtonAriaLabel.

@tsepton tsepton added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 21, 2023
@MichaelG824
Copy link
Contributor

This should be fixed with my PR.

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 26, 2023
@cetincakiroglu cetincakiroglu added this to the 17.3.0 milestone Dec 26, 2023
@cetincakiroglu cetincakiroglu added LTS-PORTABLE Issue's fix will be ported to supported LTS versions Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Dec 26, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks a lot for reporting the issue!

@cetincakiroglu
Copy link
Contributor

@MichaelG824

Sorry for fixing the issue, I couldn't see your PR. Indeed both of us fixed the same way. Closing your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants