fix: add grafana agent as dependency + fix some templates #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
davidspek
changed the title
| @@ -6,12 +6,12 @@ global: | |||
| kube-prometheus-stack: | |||
| grafana: | |||
| namespaceOverride: {{ $monitoringNamespace }} | |||
| {{- if dig "Configuration" "grafana-agent" . }} | |||
| {{- if and .Configuration (index .Configuration "grafana-agent") }} | |||
There was a problem hiding this comment.
perhaps save as a var to reference in both cases more naturally?
michaeljguarino
approved these changes
Apr 5, 2023
davidspek
force-pushed
the
trace-shield-deps
branch
from
164bd04 to
e8d7e95
Compare
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds grafana-agent as a dependency for trace shield and fixes some other application templates.
Checklist
plural from-grafanato convert a grafana dashboard found via google to our CRDpluralsh/module-libraryto accelerate this