Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bail if any custom profile-formats entries are defined in layout.conf #251

Closed
radhermit opened this issue Jan 7, 2025 · 2 comments
Closed
Labels
pkgcraft issue relating to pkgcraft

Comments

@radhermit
Copy link
Member

radhermit commented Jan 7, 2025

In this context, bailing would mean logging a repo initialization error and exiting.

Unlike what was done in pkgcore, this time around it's probably worth forcing people wanting such features to sponsor their inclusion in the spec and development. I don't think it's feasible to continue implementing features that are mainly described on a semi-obscure man page.

This should mostly be an issue for overlays as portage has (ab)used profile-formats for years in order to avoid doing the work to get features into the spec and thus have meaningful discussions about them.

@radhermit radhermit added the pkgcraft issue relating to pkgcraft label Jan 7, 2025
@radhermit radhermit changed the title consider bailing if any custom profile-formats entries are found for repos consider bailing if any custom profile-formats entries are defined in layout.conf Jan 7, 2025
@radhermit
Copy link
Member Author

radhermit commented Jan 7, 2025

Note that this currently bails if any values are defined as the default value pms isn't meant to be used by itself for regular repos and is only used when tacking extensions on top of it.

Also, it could be better to conditionally bail if profiles are accessed at all when any custom extensions are set as technically accessing repo data that doesn't relate to profiles should work as expected in most cases (e.g. generating repo pkg metadata), but this method is much cleaner to implement, will get user's attention more abruptly, and perhaps spur some action to be taken (in the next decade or two).

@radhermit
Copy link
Member Author

radhermit commented Jan 7, 2025

Finally, as a future comment to those running into this when targeting overlays using custom profile-formats (e.g. running pkgcruft scan or pk repo metadata regen), please use this as an impetus to ask for and/or work towards adding profile features you feel are missing to the spec. Portage's use of profile-formats has gone on far too long and has avoided defining even the most basic ones in the spec.

@radhermit radhermit changed the title consider bailing if any custom profile-formats entries are defined in layout.conf bail if any custom profile-formats entries are defined in layout.conf Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkgcraft issue relating to pkgcraft
Projects
None yet
Development

No branches or pull requests

1 participant