Fixed "Undefined array key -1"

phpstan · Mar 19, 2021 · cf4fc7d · cf4fc7d
1 parent 4136e00
commit cf4fc7d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Parser/TokenIterator.php b/src/Parser/TokenIterator.php
@@ -124,7 +124,7 @@ public function tryConsumeTokenType(int $tokenType): bool
 
 	public function getSkippedHorizontalWhiteSpaceIfAny(): string
 	{
-		if ($this->tokens[$this->index - 1][Lexer::TYPE_OFFSET] === Lexer::TOKEN_HORIZONTAL_WS) {
+		if ($this->index > 0 && $this->tokens[$this->index - 1][Lexer::TYPE_OFFSET] === Lexer::TOKEN_HORIZONTAL_WS) {
 			return $this->tokens[$this->index - 1][Lexer::VALUE_OFFSET];
 		}
 

diff --git a/tests/PHPStan/Parser/PhpDocParserTest.php b/tests/PHPStan/Parser/PhpDocParserTest.php
@@ -3410,6 +3410,19 @@ public function dataParseTagValue(): array
 					''
 				),
 			],
+			[
+				'@var',
+				'$foo string[]',
+				new InvalidTagValueNode(
+					'$foo string[]',
+					new \PHPStan\PhpDocParser\Parser\ParserException(
+						'$foo',
+						Lexer::TOKEN_VARIABLE,
+						0,
+						Lexer::TOKEN_IDENTIFIER
+					)
+				),
+			],
 		];
 	}