Merge pull request #543 from ciaranmcnulty/disallow-intersection-types

Disallow intersection types with a nicer error message

fixtures/IntersectionArgumentType.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Fixtures\Prophecy;
+
+class IntersectionArgumentType
+{
+    public function doSomething (Bar&Baz $foo)
+    {
+
+    }
+}

fixtures/IntersectionReturnType.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Fixtures\Prophecy;
+
+class IntersectionReturnType
+{
+    public function doSomething () : Bar&Baz
+    {
+
+    }
+}

src/Prophecy/Doubler/Generator/ClassMirror.php

@@ -16,6 +16,7 @@
 use Prophecy\Exception\InvalidArgumentException;
 use Prophecy\Exception\Doubler\ClassMirrorException;
 use ReflectionClass;
+use ReflectionIntersectionType;
 use ReflectionMethod;
 use ReflectionNamedType;
 use ReflectionParameter;
@@ -223,6 +224,12 @@ private function getTypeHints(?ReflectionType $type, ?ReflectionClass $class, bo
         elseif ($type instanceof ReflectionUnionType) {
             $types = $type->getTypes();
         }
+        elseif ($type instanceof ReflectionIntersectionType) {
+            throw new ClassMirrorException('Doubling intersection types is not supported', $class);
+        }
+        elseif(is_object($type)) {
+            throw new ClassMirrorException('Unknown reflection type ' . get_class($type), $class);
+        }
 
         $types = array_map(
             function(string $type) use ($class) {

tests/Doubler/Generator/ClassMirrorTest.php

@@ -603,4 +603,32 @@ public function it_can_double_never_return_type()
         $this->assertEquals(new ReturnTypeNode('never'), $methodNode->getReturnTypeNode());
 
     }
+
+    /**
+     * @test
+     */
+    public function it_can_not_double_intersection_return_types()
+    {
+        if (PHP_VERSION_ID < 80100) {
+            $this->markTestSkipped('Intersection types are not supported in this PHP version');
+        }
+
+        $this->expectException(ClassMirrorException::class);
+
+        $classNode = (new ClassMirror())->reflect(new \ReflectionClass('Fixtures\Prophecy\IntersectionReturnType'), []);
+    }
+
+    /**
+     * @test
+     */
+    public function it_can_not_double_intersection_argument_types()
+    {
+        if (PHP_VERSION_ID < 80100) {
+            $this->markTestSkipped('Intersection types are not supported in this PHP version');
+        }
+
+        $this->expectException(ClassMirrorException::class);
+
+        $classNode = (new ClassMirror())->reflect(new \ReflectionClass('Fixtures\Prophecy\IntersectionArgumentType'), []);
+    }
 }