fix: Amend some variables of savePolicy method

php-casbin · Aug 25, 2021 · d5f1e47 · d5f1e47
1 parent 9590645
commit d5f1e47
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 8 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/Adapter.php b/src/Adapter.php
@@ -62,13 +62,13 @@ public function loadPolicy($model): void
 
     public function savePolicy($model): void
     {
-        foreach ($model->model['p'] as $ptype => $ast) {
+        foreach ($model['p'] as $ptype => $ast) {
             foreach ($ast->policy as $rule) {
                 $this->savePolicyLine($ptype, $rule);
             }
         }
 
-        foreach ($model->model['g'] as $ptype => $ast) {
+        foreach ($model['g'] as $ptype => $ast) {
             foreach ($ast->policy as $rule) {
                 $this->savePolicyLine($ptype, $rule);
             }

diff --git a/tests/DatabaseAdapterTest.php b/tests/DatabaseAdapterTest.php
@@ -95,6 +95,20 @@ public function testAddPolicies()
         $this->assertEquals($policies, $e->getPolicy());
     }
 
+    public function testSavePolicy()
+    {
+        $e = $this->getEnforcer();
+        $this->assertFalse($e->enforce('alice', 'data4', 'read'));
+
+        $model = $e->getModel();
+        $model->clearPolicy();
+        $model->addPolicy('p', 'p', ['alice', 'data4', 'read']);
+
+        $adapter = $e->getAdapter();
+        $adapter->savePolicy($model);
+        $this->assertTrue($e->enforce('alice', 'data4', 'read'));
+    }
+
     public function testRemovePolicy()
     {
         $e = $this->getEnforcer();

diff --git a/tests/casbin-model.conf b/tests/casbin-model.conf
@@ -4,6 +4,9 @@ r = sub, obj, act
 [policy_definition]
 p = sub, obj, act
 
+[role_definition]
+g = _, _
+
 [policy_effect]
 e = some(where (p.eft == allow))