Allow disabling auto extending ActiveRecord::Base #1241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method names like `.search` can collide with existing scopes which then results in the following error: ``` You tried to define a scope named "search" on the model "…", but Active Record already defined a class method with the same name. ``` With that setting being set to `false` it allows one to enable ThinkingSphinx per model instead of globally.
|
@pat It’s been a long time that we’ve chatted about this in the RubyNZ Slack. Anyway, I’m curious whether you’d be open to this type of feature? For the moment there are no tests as I’m testing the waters. Moreover, not entirely sure how to approach testing other than creating another test app and then testing for the absence of methods on |
|
Hi @ur5us :) Very happy to have this feature, though yes, it's a hard thing to test. If you could try it out with a test app that'd be a great place to start - not sure we can do much more than that. |
|
Ended up implementing this in #1265, and is part of 5.6.0 which has just been released :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method names like
.searchcan collide with existing scopes which then results in the following error:With that setting being set to
falseit allows one to enable ThinkingSphinx per model instead of globally.