Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Tagging chain for jsonrpsee log #12131

Open
2 tasks done
jasl opened this issue Aug 29, 2022 · 3 comments
Open
2 tasks done

Tagging chain for jsonrpsee log #12131

jasl opened this issue Aug 29, 2022 · 3 comments

Comments

@jasl
Copy link
Contributor

jasl commented Aug 29, 2022

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

This is extracted from #11768

image_2022-07-01_16-43-46

It's quite unclear that which chain get a new connection or disconnected

And, WS error: i/o error: Transport endpoint is not connected (os error 107); terminate connection 6 is the client force disconnect so I propose it move to WARN level and give a more clear log

khala-parachain node is based on polkadot-v0.9.27 Cumulus which still has this behavior, so it might not tracing bug

Steps to reproduce

No response

@bkchr
Copy link
Member

bkchr commented Aug 29, 2022

@niklasad1 jsonrpsee is using its own thread pool or? If yes, the problem is that this is missing:

Basically forwarding of the current tracing span, that provides these information to which node the log belongs.

@niklasad1
Copy link
Member

niklasad1 commented Aug 29, 2022

@niklasad1 jsonrpsee is using its own thread pool or? If yes, the problem is that this is missing:

No, it uses the tokio runtime from sc-cli /~https://github.com/paritytech/substrate/blob/master/client/rpc-servers/src/lib.rs#L159 (unless I have introduced a bug somewhere)

@bkchr
Copy link
Member

bkchr commented Aug 29, 2022

@niklasad1 jsonrpsee is using its own thread pool or? If yes, the problem is that this is missing:

No, it uses the tokio runtime from sc-cli /~https://github.com/paritytech/substrate/blob/master/client/rpc-servers/src/lib.rs#L159 (unless I have introduced a bug somewhere)

Ahh yeah that looks right. However, we don't use the substrate task manager facilities.

We need to be able to pass some custom spawn function. So that we can instrument the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants