-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to parity-scale-codec 3
and scale-info 2
#1132
Conversation
3
and scale-info 2
Codecov Report
@@ Coverage Diff @@
## master #1132 +/- ##
==========================================
- Coverage 78.70% 78.66% -0.05%
==========================================
Files 253 253
Lines 9411 9411
==========================================
- Hits 7407 7403 -4
- Misses 2004 2008 +4
Continue to review full report at Codecov.
|
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Tue Feb 15 12:01:01 CET 2022 |
Still strange that gas doesn't change for all contracts where the size changed. Is the size change maybe in a path that isn't hit by the waterfall? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still strange that gas doesn't change for all contracts where the size changed. Is the size change maybe in a path that isn't hit by the waterfall?
I also find it strange, I can create a follow-up issue in the waterfall to look into it.
Supersedes #1124