Fix for HABTM associations when updated within 1 transaction #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -526,7 +526,7 @@ def save_associations_has_and_belongs_to_many(version) | |||
| self.class.paper_trail_save_join_tables.include?(a.name) || | |||
| a.klass.paper_trail_enabled_for_model? | |||
| assoc_version_args = { | |||
| version_id: version.id, | |||
| version_id: version.transaction_id, | |||
There was a problem hiding this comment.
Remind me again why we store transaction_id in the version_id column? Is it because there is no "through" table in a HABTM?
|
This looks good, thanks Sam. Please add a changelog entry. |
When updating 2 models with a HABTM association, and using accepts_nested_attributes_for, the association was using the version ID instead of the transaction ID to reference the change. This was braking the association logic and preventing proper reification.
|
Thanks, Sam! Merged offline as 4ad6254 with tiny fix to changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating 2 models with a HABTM association, and using
accepts_nested_attributes_for, the association was using the
version ID instead of the transaction ID to reference the change.
This was braking the association logic and preventing proper
reification.