Error out if the text isn't given as a string

#8 (comment)
papandreou · Jul 1, 2021 · f4a5297 · f4a5297 · zonyitoo · Jul 1, 2021
1 parent 0e7fc87
commit f4a5297
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -20,6 +20,10 @@ async function subsetFont(
   text,
   { targetFormat = fontverter.detectFormat(originalFont), preserveNameIds } = {}
 ) {
+  if (typeof text !== 'string') {
+    throw new Error('The subset text must be given as a string');
+  }
+
   const [exports, heapu8] = await loadAndInitializeHarfbuzz();
 
   originalFont = await fontverter.convert(originalFont, 'truetype');

diff --git a/test/index.js b/test/index.js
@@ -25,6 +25,16 @@ describe('subset-font', function () {
       );
     });
 
+    describe('when not supplying the subset text as a string', function () {
+      it('should fail with an error', async function () {
+        await expect(
+          () => subsetFont(this.sfntFont, ['f', 'o', 'o']),
+          'to error with',
+          'The subset text must be given as a string'
+        );
+      });
+    });
+
     describe('with no targetFormat given', function () {
       it('should return the subset as truetype', async function () {
         const result = await subsetFont(this.sfntFont, 'abcd');