fix: loopback redirectUriAllowed protocol check #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition `!parsed.protocol === 'http:'` always returns `false`. The `!` operator has a higher precedence than the `===` operator. `parsed.protocol` is a string, so negating it would be `false`. Then, it's clear that `false === 'http:'` is always `false`. It seems that the intended check was `parsed.protocol !== 'http:'`.
panva
approved these changes
Oct 3, 2020
panva
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition
!parsed.protocol === 'http:'always returnsfalse. The!operator has a higher precedence than the===operator.parsed.protocolis a string, so negating it would befalse. Then, it's clear thatfalse === 'http:'is alwaysfalse.It seems that the intended check was
parsed.protocol !== 'http:'.