fix: ignore sector_identifier_uri when subject_type is not pairwise

panva · Sep 30, 2018 · 416e379 · 416e379
1 parent 3a01a6f
commit 416e379
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/lib/helpers/client_schema.js b/lib/helpers/client_schema.js
@@ -275,6 +275,10 @@ module.exports = function getSchema(provider) {
         }
       }
 
+      if (this.sector_identifier_uri !== undefined && this.subject_type !== 'pairwise') {
+        this.sector_identifier_uri = undefined;
+      }
+
       // SECTOR IDENTIFIER VALIDATION
       sectorIdentifier({
         subjectType: this.subject_type,

diff --git a/test/pairwise/pairwise_clients.test.js b/test/pairwise/pairwise_clients.test.js
@@ -71,6 +71,19 @@ describe('pairwise features', () => {
     });
 
     context('sector_identifier_uri is provided', () => {
+      it('is ignored unless pairwise subject_type is used', function () {
+        return i(this.provider).clientAdd({
+          client_id: 'client',
+          client_secret: 'secret',
+          redirect_uris: ['https://client.example.com/cb', 'https://another.example.com/forum/cb'],
+          sector_identifier_uri: 'https://foobar.example.com/file_of_redirect_uris',
+          subject_type: 'public',
+        }).then((client) => {
+          expect(client).to.be.ok;
+          expect(client.sectorIdentifier).to.eq(undefined);
+        });
+      });
+
       it('validates the sector from the provided uri', function () {
         nock('https://foobar.example.com')
           .get('/file_of_redirect_uris')
@@ -85,8 +98,6 @@ describe('pairwise features', () => {
         }).then((client) => {
           expect(client).to.be.ok;
           expect(client.sectorIdentifier).to.eq('foobar.example.com');
-        }, (err) => {
-          expect(err).not.to.be.ok;
         });
       });