[#IOCOM-538] Add "..." at the end of the message content when it's tr…

…uncated (#280)
pagopa · Sep 18, 2023 · aa9677b · aa9677b
1 parent c9e98d6
commit aa9677b
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 4 deletions.
diff --git a/EmailNotification/__tests__/__snapshots__/utils.test.ts.snap b/EmailNotification/__tests__/__snapshots__/utils.test.ts.snap
@@ -388,7 +388,7 @@ Object {
                               </tr>
                               <tr>
                                 <td align=\\"left\\" class=\\"text\\" style=\\"font-size:0px;padding:0px;word-break:break-word;\\">
-                                  <div style=\\"font-family:Titillium Web, system-ui, sans-serif;font-size:16px;font-weight:regular;line-height:24px;text-align:left;color:#17324D;\\"><p>testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttestte</p></div>
+                                  <div style=\\"font-family:Titillium Web, system-ui, sans-serif;font-size:16px;font-weight:regular;line-height:24px;text-align:left;color:#17324D;\\"><p>testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttestte...</p></div>
                                 </td>
                               </tr>
                             </tbody>

diff --git a/EmailNotification/__tests__/handler.test.ts b/EmailNotification/__tests__/handler.test.ts
@@ -225,7 +225,8 @@ describe("prepareBody", () => {
     const markdown =
       "# Header 1\nsome text\n## Header 2\nsome text\n### Header 3\nsome text\n#### Header 4\nsome text\n##### Header 5\nsome text\ntestesttesttesttestesttesttesttestesttesttesttestesttesttesttestesttesttesttestesttesttest";
     const r = prepareBody(markdown);
-    expect(r).toHaveLength(134);
+    //this should be 134 + 3 cause "..." is added at the end
+    expect(r).toHaveLength(137);
     expect(r).not.toContain("#");
   });
 });
diff --git a/EmailNotification/__tests__/utils.test.ts b/EmailNotification/__tests__/utils.test.ts
@@ -1,4 +1,8 @@
-import { contentToHtml, messageReducedToHtml } from "../utils";
+import {
+  contentToHtml,
+  messageReducedToHtml,
+  truncateMarkdown
+} from "../utils";
 import * as E from "fp-ts/Either";
 import {
   aCreatedMessageEventSenderMetadata,
@@ -52,3 +56,14 @@ describe("messageReducedToHtml", () => {
     expect(result).toEqual(E.left(anError));
   });
 });
+
+describe("truncateMarkdown", () => {
+  test("should add '...' at the end of the string if the plain text length is > 134", () => {
+    expect(truncateMarkdown(aMessageContent.markdown).slice(-3)).toBe("...");
+  });
+  test("should not add '...' at the end of the string if the plain text length is <= 134", () => {
+    expect(truncateMarkdown("This message is < than 134 chars")).not.toContain(
+      "..."
+    );
+  });
+});
diff --git a/EmailNotification/utils.ts b/EmailNotification/utils.ts
@@ -108,7 +108,10 @@ type MessageReducedToHtmlInput = {
 };
 
 export const truncateMarkdown = (plainText: string): string =>
-  plainText.substring(0, MAX_CHARACTER_FOR_BODY_MAIL);
+  // we add "..." only when the message is going to be truncate
+  plainText.length > MAX_CHARACTER_FOR_BODY_MAIL
+    ? plainText.substring(0, MAX_CHARACTER_FOR_BODY_MAIL) + "..."
+    : plainText.substring(0, MAX_CHARACTER_FOR_BODY_MAIL);
 
 export const prepareBody = (markdown: string): string =>
   // eslint-disable-next-line functional/immutable-data