Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all underscores are replaced with dashes for PyPi packages #23

Closed
ghost opened this issue Jul 20, 2021 · 3 comments
Closed

Not all underscores are replaced with dashes for PyPi packages #23

ghost opened this issue Jul 20, 2021 · 3 comments

Comments

@ghost
Copy link

ghost commented Jul 20, 2021

Hello.

We have used the library and it works good for us in most of cases.

But we noticed the following issue: according to the pURL specification, for PyPi packages all underscores "_" must be replaced with dashes "-" in the name. However, it seems as if only the first occurrence is replaced using "someString.replace(...)".

Can you please have a look at this?
(There are also other usages of replace function.)

Thank you very much,
Pavel

@DarthHater
Copy link
Contributor

@pkomardin , myself and @declanhunter took a gander at this today, and fixed JUST the pypi issue (trying to keep the PR narrow). It's at #26 if you wanted to take a gander. If you find other issues, I'd raise them! Thanks for raising this.

@ghost
Copy link
Author

ghost commented Mar 29, 2022

... hi, thank you for having fixed that!!! We are looking forward for the next library version.

@steven-esser
Copy link
Collaborator

@pkomardin @DarthHater @declanhunter v0.0.6 of packageurl-js published to NPM, with your fix to this issue included: https://www.npmjs.com/package/packageurl-js/v/0.0.6

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants