Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitsigns.nvim blame virtual text not displaying #19

Closed
gnoeyp opened this issue Oct 5, 2023 · 12 comments
Closed

gitsigns.nvim blame virtual text not displaying #19

gnoeyp opened this issue Oct 5, 2023 · 12 comments

Comments

@gnoeyp
Copy link

gnoeyp commented Oct 5, 2023

I'm trying to use this theme and git signs for line blame. A virtual text is supposed to be shown but I only see an icon with no text (as the picture shows below). Is it possible to customize the color scheme to fix this, or do you have any plan to update for supporting git signs?

스크린샷 2023-10-06 오전 1 19 50

@oxfist
Copy link
Owner

oxfist commented Oct 5, 2023

Hi @gnoeyp! Gitsigns should definitely work so I might have messed up a highlight group. Happy to help get this fixed for you.

Can you tell me what's the output when you run :verbose hi GitSignsCurrentLineBlame and :verbose hi NonText inside neovim?

@gnoeyp
Copy link
Author

gnoeyp commented Oct 6, 2023

This is the output! Thank you :)
스크린샷 2023-10-06 오전 10 04 34
스크린샷 2023-10-06 오전 10 04 48

@oxfist oxfist closed this as completed in 1b5769a Oct 13, 2023
@oxfist
Copy link
Owner

oxfist commented Oct 13, 2023

@gnoeyp I just pushed a change that explicitly sets the GitSignsCurrentLineBlame hl group rather than linking it to NonText, can you update the plugin and test on your end if the issue is still there?

@gnoeyp
Copy link
Author

gnoeyp commented Oct 13, 2023

@oxfist I just updated and checked that GitSignsCurrentLineBlame color is set. But the issue still appears.

스크린샷 2023-10-13 오후 11 03 35
스크린샷 2023-10-13 오후 11 08 19

@oxfist
Copy link
Owner

oxfist commented Oct 13, 2023

@gnoeyp Thanks for the update! Sorry the issue is still there, I have three requests 🙏🏼 :

  1. Can you see the blame text after running the following? :hi GitSignsCurrentLineBlame guifg=red
  2. Can you tell me which Neovim version you're running from the output of nvim --version?
  3. Can you test if you can see the blame text by disabling all plugins except for this theme? I'm unsure what the root cause of this issue is but it is possible that it's being caused by other plugin

@oxfist oxfist reopened this Oct 13, 2023
@oxfist oxfist changed the title Git signs virtual text not displaying gitsigns.nvim blame virtual text not displaying Oct 13, 2023
@gnoeyp
Copy link
Author

gnoeyp commented Oct 13, 2023

I see the blame text if I set :hi GitSignsCurrentLineBlame guifg=red. I think it's because blame text has the same color with background (#011627).

@gnoeyp
Copy link
Author

gnoeyp commented Oct 13, 2023

Maybe it should be visual = "#1d3b53" ?

@oxfist
Copy link
Owner

oxfist commented Oct 13, 2023

I think you might be on the right track. I understand why this might be happening if GitSignsCurrentLuneBlame and the background are the exact same value, BUT CursorLine, which represents the active line, is set to a darker background to provide visual feedback of the line you're in. This is the original's theme default behavior.

What do you get with :hi CursorLine?

Also, can you share your gitsigns config here so I can try and reproduce your issue?

@oxfist
Copy link
Owner

oxfist commented Oct 13, 2023

I suspect you might not have cursorline enabled, you can try what you see on the blame line with :set cursorline. Although this shouldn't be required I think there might be still an issue.

I just ran :hi GitSignsCurrentLineBlame guifg=red guibg=red and see this, so I'm confident there's something messing up with the opacity or color of that hl group, since you can still see the text in the screenshot below:

CleanShot 2023-10-13 at 1 53 23@2x

@oxfist oxfist closed this as completed in dd99d60 Nov 8, 2023
@oxfist
Copy link
Owner

oxfist commented Nov 8, 2023

@gnoeyp I was able to reproduce this consistently after disabling some transparency settings in my terminal 🤦🏼 Sorry about that! It should be fixed now

@oxfist
Copy link
Owner

oxfist commented Nov 8, 2023

@all-contributors please add @gnoeyp for bug

Copy link
Contributor

@oxfist

I've put up a pull request to add @gnoeyp! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants