Decompression error when folder already exists at the place of output file

[marcospb19]

Ouch doens't really know that there is a folder there, it just gives this error message.

When it's not a folder, but a simple text file, it does ask if should overwrite.

[SpyrosRoum]

Should we ask to overwrite if there is a directory as well or simply improve the error message?

[marcospb19]

I think we should ask like we do for other regular files.

[SpyrosRoum]

When it's not a folder, but a simple text file, it does ask if should overwrite.

Unless I'm doing something wrong, this is not true, it simply overwrite the file:

[marcospb19]

Try it with an archive format, seems like overwrite questions are not being asked for single-file compression formats (like .gz .xz .bz .zst)? If so, that should be another new issue.

[SpyrosRoum]

I think the issue in essentially the same and I'm in the process of fixing it all so is it okay if I do them in the same pr?

[marcospb19]

Sure!

[marcospb19]

Still an issue, probably at:

ouch/src/utils/fs.rs

Lines 23 to 30 in 7a4dcb2

	/// Creates the dir if non existent.
	pub fn create_dir_if_non_existent(path: &Path) -> crate::Result<()> {
	if !path.exists() {
	fs::create_dir_all(path)?;
	info!("directory {} created.", to_utf(path));
	}
	Ok(())
	}

How to reproduce:

[SpyrosRoum]

Hm I guess I missed that case but it seems like an easy fix