floorchange unpass objects

[ghost]

Before creating an issue, please ensure:

• This is a bug in the software that resides in this repository, and not a
  support matter (use https://otland.net/forums/support.16/ for support)
• This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

1. place 3 parcels and try to go up a floor onto an "unpass" object like a statue or trough
2. try to stack 2 unpassable objects aswell by pushing them into floorchange, you will get same result "not enough room"

Expected behaviour

tested on rl-tibia and it should be possible

Actual behaviour

"there is not enough room."

Environment

Reproduction environment

[ghost]

maybe it was possible on 10.98 version, we will have to wait for version 12.x to try it again since we can't test on official 10.98 anymore, unless we find a video

[Zbizu]

forgottenserver/src/game.cpp

Line 807 in c9a65a8

if (tmpTile == nullptr || (tmpTile->getGround() == nullptr && !tmpTile->hasFlag(TILESTATE_BLOCKSOLID))) {

forgottenserver/src/game.cpp

Line 823 in c9a65a8

if (tmpTile == nullptr || (tmpTile->getGround() == nullptr && !tmpTile->hasFlag(TILESTATE_BLOCKSOLID))) {

my guess is that we have to use something other than TILESTATE_BLOCKSOLID

we could try TILESTATE_IMMOVABLEBLOCKSOLID, but I'm not sure if it's working properly

[ghost]

added another example with stacking items by floorchange

[ghost]

maybe it was possible on 10.98 version, we will have to wait for version 12.x to try it again since we can't test on official 10.98 anymore, unless we find a video

version 7.7 works the same as tibia 12.71, so doubt any difference on 10.98

[Zbizu]

Yeah it was like that since feature introduction probably. Please test if my pull request fixes the issue.

[ghost]

Yeah it was like that since feature introduction probably. Please test if my pull request fixes the issue.

yes it is working, only thing left is stacking those items by adding into floorchange like on the second picture

[Zbizu]

hey, do you play on pvp world? Please test if you can levitate/parcelwalk towards magic walled tiles

[ghost]

hey, do you play on pvp world? Please test if you can levitate/parcelwalk towards magic walled tiles

you cannot, also teleport effect on levitate and magic rope should be sent on previous position

[Zbizu]

I'll look into magic rope later. I've added a commit that changes how magic effect is launched for levitate. Check if the spell is 100% accurate now.

[ghost]

I'll look into magic rope later. I've added a commit that changes how magic effect is launched for levitate. Check if the spell is 100% accurate now.

ye levitate seems to be alright now, i only noticed that it seems to be case sensitive for the parameter

[Zbizu]

added a commit to ignore case sensitivity and spaces in param

[ghost]

@DSpeichert you could atleast read before randomly closing, that PR didnt fix all

[Zbizu]

what else is here to do?

[ghost]

what else is here to do?

• read number 2 in the reproduce steps, check second image if you don't get it
• we talked about magic rope

[ghost]