fix: content-webapp messaging with postMessage for firefox #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jossef
reviewed
Mar 19, 2023
src/events-shared.js
Outdated
| @@ -5,6 +5,13 @@ export const RESPONSE_PACKAGE_INFO_EVENT = overlayPrefix + 'RESPONSE_PACKAGE_INF | |||
| export const READY_EVENT = overlayPrefix + 'READY_EVENT'; | |||
|
|
|||
| export const dispatchEvent = (type, detail) => { | |||
| const event = new CustomEvent(type, { detail }); | |||
| window.dispatchEvent(event); | |||
| window.postMessage({ type, detail }, '*'); | |||
There was a problem hiding this comment.
Is the * part of a test or purposely there?
There was a problem hiding this comment.
A target origin can be specified using the
targetOriginmember of options. If not provided, it defaults to "/". This default restricts the message to same-origin targets only.
I kept it as default, it is what we need.
jossef
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here, and I can't find the official documentation right now, but for security reasons, Firefox desn't allow to pass an object inside a CustomEvent between content-script and the host app.
You have to
cloneIntoit or something.