Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A useless postage was added to the sending runes tx? #3620

Closed
ZhiGuang opened this issue Apr 19, 2024 · 2 comments · Fixed by #3484
Closed

A useless postage was added to the sending runes tx? #3620

ZhiGuang opened this issue Apr 19, 2024 · 2 comments · Fixed by #3484

Comments

@ZhiGuang
Copy link

Query Balance:

PS D:\Projects\bitcoin\ord> ordtest wallet balance
{ "cardinal": 46553843, "ordinal": 20000, "runes": { "xxxxxxx": "1000000", "MEME•OF•RUNES": "24", "xxxxxxx": "381000000", "xxxxxxx": "20000" }, "runic": 1450000, "total": 48023843 }

send runes:
PS D:\Projects\bitcoin\ord> ordtest wallet send --fee-rate 100 tb1pt0v7eye37l38e50lnywfu6atj2ec6dzteduqa4xasqnn6ndckcuqx83fsn 24:MEME•OF•RUNES
{ "txid": "07537f2643f790535e12a2211f78ec82e2cfef866b694ba6d653a2caecf592f9", "psbt": "xxxx", "outgoing": "24:MEME•OF•RUNES", "fee": 27600 }

The payload in OP_RETURN:
0099ee9d0110e01202

Dechiper result:
{"edicts":[{"id":{"block":"2586393","tx":"16"},"amount":"2400","output":"2"}]}

Tx in mempool

This transaction only requires one postage, why are there two postage outputs in the transaction?

@gmart7t2
Copy link
Contributor

I have the same problem.

When you send runes, ord always creates 3 outputs: 1 for the op_return, one for the change runes, and one for the outgoing runes.

If you are sending all the runes from the input utxos, there is no need for a change output but it is created anyway.

@gmart7t2
Copy link
Contributor

There should be a check for the case where you are sending the whole runic balance of the input utxos, because in that case no change or op_return is required. We can just send the inputs to the output and rely on the fact that the lack of an edict makes all the input runes go to the first output.

@raphjaph raphjaph added the bug label Apr 22, 2024
@raphjaph raphjaph added this to Tracker Apr 22, 2024
@raphjaph raphjaph moved this to To Do in Tracker Apr 22, 2024
@raphjaph raphjaph moved this from To Do to In Progress in Tracker Apr 23, 2024
@raphjaph raphjaph moved this from In Progress to Ready for Review in Tracker Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants