Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript could not find module declaration to resolve typing. #59

Closed
binodnepali opened this issue Sep 12, 2023 · 2 comments · Fixed by #60
Closed

Typescript could not find module declaration to resolve typing. #59

binodnepali opened this issue Sep 12, 2023 · 2 comments · Fixed by #60
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@binodnepali
Copy link
Member

Describe the bug
When I try to import package using es module system in ts project. I am getting type declaration module not found and I have attached screenshot.

To Reproduce
Just import package.
import NepaliDate from 'nepali-datetime'

Expected behavior
There should not error and type completion should be working

Environment

  • npm/node version: 9.5.0/18.14.2
  • Package version: ^1.1.0
  • Operating system: macOS ventura 13.5.1
  • Any other relevant information about your environment.

Additional context
Please provide any additional context or information that may be helpful in understanding and resolving the issue. This can include:

  • Screenshots
error
@binodnepali binodnepali added bug Something isn't working help wanted Extra attention is needed labels Sep 12, 2023
@aj3sh aj3sh closed this as completed in #60 Sep 13, 2023
@aj3sh
Copy link
Member

aj3sh commented Sep 13, 2023

@binodnepali, Do we have to release a patch for this fix? Or can we wait for the minor release?

@binodnepali
Copy link
Member Author

@aj3sh It would be awesome to release patch for this. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants