Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent Support for newer JDK's #722

Closed
onelapahead opened this issue Oct 11, 2018 · 8 comments
Closed

Agent Support for newer JDK's #722

onelapahead opened this issue Oct 11, 2018 · 8 comments

Comments

@onelapahead
Copy link

Using /~https://github.com/jenkinsci/kubernetes-plugin#container-group-support and the https://hub.docker.com/_/maven/ image, we're able to build newer Java apps with a custom agent defined in a configmap very easily. However, it'd be awesome if future OpenShift releases came with Maven agent images for JDK's 9 - 11... is that on the roadmap for you guys?

@gabemontero
Copy link
Contributor

Not at this time @brix4dayz ... looked at you git profile, reminded myself you are at bandwidth

You all at bandwidth should file an RFE if this is important to you.

@sspeiche - fyi

@andyfeller
Copy link

@gabemontero : just to confirm the expectation is that Redhat is supporting OpenJDK 8 until 2023 including the OpenShift Docker images here, yes?

@fschmager
Copy link

I can understand if would want to skip 9 and 10, but you gotta consider doing 11. Pretty much everyone was waiting for 11 because long term support and all that jazz. Just outright rejecting supporting anything newer than 8 doesn't sound right to me.
Don't get me wrong. I appreciate this project existing and all the work you put into supporting it, but please reconsider your stance on "never anything newer".

@andyfeller
Copy link

andyfeller commented Oct 11, 2018

@fschmager: all of the Docker images produced by Redhat for OpenShift are built on OpenJDK, which have a different support cycle than Oracle, so there might be more time for applications on JDK 8 to upgrade to JDK 11.

@bparees
Copy link
Contributor

bparees commented Oct 11, 2018

Just outright rejecting supporting anything newer than 8 doesn't sound right to me.
Don't get me wrong. I appreciate this project existing and all the work you put into supporting it, but please reconsider your stance on "never anything newer".

Nothing was rejected, @gabemontero requested an RFE be submitted because that is the only way we are going to be able to prioritize this work. It's too large of a feature for us to just handle it as a one-off in someone's spare time, which is basically how github issues (especially ones that are not bugs) get done.

I would also point out that the jenkins agent images we provide are to some extent just intended as "here's a working example". If they work for you, great. If they don't, extend/modify them as needed. That is why we publish the slave-base image, so you have a ready extension point.

@mguillem
Copy link

mguillem commented Mar 6, 2019

The slave-base image is not optimal as base image for a slave image using an other JDK as the "multi-arch check" in slave-base/contrib/bin/run-jnlp-client calls alternatives and may change the configured JDK. Personally I've just installed JDK11 on top of the base image and removed the problematic part of run-jnlp-client (/~https://github.com/mguillem/openshift-jenkins-maven-slave/) but it is still not optimal as JDK8 is still contained in the image.
If there is interest, I can prepare a pull request here to provide a cleaner maven slave based on OpenJDK11.

@bparees
Copy link
Contributor

bparees commented Mar 6, 2019

The slave-base image is not optimal as base image for a slave image using an other JDK as the "multi-arch check" in slave-base/contrib/bin/run-jnlp-client calls alternatives and may change the configured JDK. Personally I've just installed JDK11 on top of the base image and removed the problematic part of run-jnlp-client

Someone with that concern can set the jvm arch env variable as part of their extending of the image to force the arch they want...

Anyway we are likely going to be removing the 32/64bit split soon and just always running 64bit.

If there is interest, I can prepare a pull request here to provide a cleaner maven slave based on OpenJDK11.

Our challenge with this is how to provide it w/o breaking people on jdk8. It really needs to be made available as a new image/repository (vs just being a new version of the existing image). We're having similar discussions/debates w/ respect to the nodejs agent. I would like to see us move away from providing configuration in the jenkins master that points to specific agent images, and instead move to a model where there is just a catalog of agent images (published by various people) that the jenkins master can be configured(by the end user) to use.

To that end, I think a great starting point would be to publish your jdk11 based agent images and submit a PR to the readme here referencing them.

@andyfeller
Copy link

This appears to have been done as part of #913 for upgrading the sync plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants