Expect to change Lombok AllArgsConstructor going forward

openrewrite · Feb 5, 2025 · bc40657 · bc40657
1 parent e9d71c5
commit bc40657
Showing 1 changed file with 33 additions and 20 deletions.
diff --git a/src/test/java/org/openrewrite/java/migrate/util/MigrateCollectionsSingletonListTest.java b/src/test/java/org/openrewrite/java/migrate/util/MigrateCollectionsSingletonListTest.java
@@ -42,15 +42,15 @@ void templateError() {
           java(
             """
               import java.util.*;
-              
+
               interface ConnectionListener {
                void onCreate();
               }
-              
+
               class A {
                   public void setConnectionListeners(List<? extends ConnectionListener> listeners) {
                   }
-              
+
                   public void test() {
                       setConnectionListeners(Collections.singletonList(new ConnectionListener() {
                           @Override
@@ -62,15 +62,15 @@ public void onCreate() {
               """,
             """
               import java.util.List;
-              
+
               interface ConnectionListener {
                void onCreate();
               }
-              
+
               class A {
                   public void setConnectionListeners(List<? extends ConnectionListener> listeners) {
                   }
-              
+
                   public void test() {
                       setConnectionListeners(List.of(new ConnectionListener() {
                           @Override
@@ -93,14 +93,14 @@ void singletonList() {
           java(
             """
               import java.util.*;
-              
+
               class Test {
                   List<String> list = Collections.singletonList("ABC");
               }
               """,
             """
               import java.util.List;
-              
+
               class Test {
                   List<String> list = List.of("ABC");
               }
@@ -118,14 +118,14 @@ void singletonListStaticImport() {
             """
               import java.util.*;
               import static java.util.Collections.singletonList;
-              
+
               class Test {
                   List<String> list = singletonList("ABC");
               }
               """,
             """
               import java.util.List;
-              
+
               class Test {
                   List<String> list = List.of("ABC");
               }
@@ -143,15 +143,15 @@ void singletonListCustomType() {
             """
               import java.util.*;
               import java.time.LocalDate;
-              
+
               class Test {
                   List<LocalDate> list = Collections.singletonList(LocalDate.now());
               }
               """,
             """
               import java.util.List;
               import java.time.LocalDate;
-              
+
               class Test {
                   List<LocalDate> list = List.of(LocalDate.now());
               }
@@ -164,27 +164,40 @@ class Test {
     @Test
     void lombokAllArgsConstructor() {
         rewriteRun(
-          spec -> spec.parser(JavaParser.fromJavaVersion().classpath("lombok"))
-            .typeValidationOptions(TypeValidation.builder().constructorInvocations(false).build()),
+          spec -> spec.parser(JavaParser.fromJavaVersion().classpath("lombok")),
           //language=java
           java(
             """
               import lombok.AllArgsConstructor;
               import java.util.List;
-              
+
               import static java.util.Collections.singletonList;
-              
+
               enum FooEnum {
                   FOO, BAR;
-              
+
                   @AllArgsConstructor
                   public enum BarEnum {
                       foobar(singletonList(FOO));
-              
+
                       private final List<FooEnum> expectedStates;
                   }
               }
-              """
+              """,
+            """
+              import lombok.AllArgsConstructor;
+              import java.util.List;
+
+              enum FooEnum {
+                  FOO, BAR;
+
+                  @AllArgsConstructor
+                  public enum BarEnum {
+                      foobar(List.of(FOO));
+
+                      private final List<FooEnum> expectedStates;
+                  }
+              }"""
           )
         );
     }
@@ -197,7 +210,7 @@ void shouldNotConvertLiteralNull() {
           java(
             """
               import java.util.*;
-              
+
               class Test {
                   List<String> list = Collections.singletonList(null);
               }