Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pilight] Pilight Binding initial contribution #8469

Closed
wants to merge 1 commit into from

Conversation

stefanroellin
Copy link
Contributor

Signed-off-by: Stefan Roellin stefan@roellin-baumann.ch

The Pilight binding allows openHAB to communicate with a pilight instance running pilight version 6.0 or greater.
This pull request is meant to port the corresponding binding from openhab1-addons (https://www.openhab.org/addons/bindings/pilight1/) to openHAB 2.

Signed-off-by: Stefan Roellin <stefan@roellin-baumann.ch>
@stefanroellin stefanroellin requested a review from a team as a code owner September 13, 2020 20:06
@Hilbrand Hilbrand added new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 labels Sep 13, 2020
@stefanroellin
Copy link
Contributor Author

The Travis CI - Pull Request fails unrelated to this plugin, see https://travis-ci.com/github/openhab/openhab-addons/jobs/384407662

...
SEVERE: Step 'eclipse wtp formatters - XML' found problem in 'bundles/org.openhab.binding.heos/src/main/feature/feature.xml':
java.lang.ClassNotFoundException: com.diffplug.spotless.extra.eclipse.wtp.EclipseXmlFormatterStepImpl
com.diffplug.common.base.Errors$WrappedAsRuntimeException: java.lang.ClassNotFoundException: com.diffplug.spotless.extra.eclipse.wtp.EclipseXmlFormatterStepImpl
....
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.0.3:check (codestyle_check) on project org.openhab.addons.reactor: Execution codestyle_check of goal com.diffplug.spotless:spotless-maven-plugin:2.0.3:check failed: java.lang.ClassNotFoundException: com.diffplug.spotless.extra.eclipse.wtp.EclipseXmlFormatterStepImpl -> [Help 1]
....

Can a maintainer solve this error?

@TravisBuddy
Copy link

Travis tests were successful

Hey @stefanroellin,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@Hilbrand
Copy link
Member

The travis build failed due for unclear reasons, but seems to have succeeded here. The other Jenkins build, failed due to a timeout. The timout has been increased so it should succeed the next time you would trigger a build.

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 16, 2020
@wborn
Copy link
Member

wborn commented Sep 16, 2020

It was me who retriggered Travis and now also Jenkins. 😉

@openhab-bot
Copy link
Collaborator

Automatic code migration to openHAB 3 succeeded.

The resulting code can be found at https://ci.openhab.org/job/openHAB-Addons-Migration/70/artifact/bundles/.

You can download the migrated code from there and create a new PR against the master branch of the openhab-addons repo to contribute it for being included in openHAB 3.x.

Please see this issue about the details on how to proceed with your existing PR.

@kaikreuzer
Copy link
Member

Closing this PR as it is not in a mergeable state. Please follow the instructions to port this PR to the main branch for openHAB 3.

@kaikreuzer kaikreuzer closed this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants