Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pushover] Move sound configuration parameter from Thing to Channel #9701

Closed
sihui62 opened this issue Jan 5, 2021 · 1 comment · Fixed by #10422
Closed

[pushover] Move sound configuration parameter from Thing to Channel #9701

sihui62 opened this issue Jan 5, 2021 · 1 comment · Fixed by #10422
Assignees
@cweitkamp
Labels
enhancement An enhancement or new feature for an existing add-on PR pending There is a pull request for resolving the issue

Comments

@sihui62
Copy link
Contributor

sihui62 commented Jan 5, 2021

Would it be possible to move the configuration parameter for the sound notification from Things to Channels?

Currently you have to setup multiple Things to get a different sound.

According to the openHAB concepts page it would be more appropriate to have that parameter for the Channels.

Discussion on this already started in the community:
https://community.openhab.org/t/pushover-binding-in-oh3-help-needed/111361/8
@sihui62 sihui62 added the enhancement An enhancement or new feature for an existing add-on label Jan 5, 2021
@sihui62 sihui62 changed the title [pushover] Move sound configration parameter from Thing to Channel [pushover] Move sound configuration parameter from Thing to Channel Jan 5, 2021
@cweitkamp cweitkamp self-assigned this Jan 12, 2021
@cweitkamp cweitkamp added the PR pending There is a pull request for resolving the issue label Mar 30, 2021
@cweitkamp cweitkamp mentioned this issue Mar 30, 2021
Merged
@cweitkamp
Copy link
Contributor

I added a universal method in #10422 which allows to pass any possible parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cweitkamp cweitkamp

Labels
enhancement An enhancement or new feature for an existing add-on PR pending There is a pull request for resolving the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pushover] Added universal action providing all available parameters cweitkamp/openhab-addons
2 participants
@cweitkamp @sihui62