Activating cache for TTS services

[lolodomo]

A LRU cache is available in core framework. The use of this cache has to be enabled for each TTS service:
An option exists to disable the cache..

• Google TTS : PR [googletts] Replace custom TTS cache with common TTS cache #15208
• macOS TTS : PR [mactts] Add LRU cache #15109
• Mary TTS: PR [marytts] Add LRU cache #15227
• Mimic TTS : PR [mimictts] Add LRU cache #14564
• Pico TTS : PR [picotts] Add LRU cache #14565
• Polly TTS : PR [pollyTTS] Replace custom TTS cache with common TTS cache #15228
• VoiceRSS TTS: PR [voicerss] Add LRU cache #14561

[lolodomo]

For Polly TTS, do we remove the existing cache system or do we let the user choose what cache system to be used (through a new option) ?

[lolodomo]

Same question for Google TTS.

[lolodomo]

Regarding Mimic and VoiceRSS TTS, it is better to wait for the enhancement of all audio sinks before merging the related PRs.

[dalgwen]

Same question for Google TTS.

As you saw, I forgot your question and directly provided a Google TTS PR...

I have no doubt that the common cache has more functionnality than the custom google one.
(I didn't look at Polly TTS recently but I think it is nearly the same). I think we should make the shift, on the paper at least.

My last concern is : is there some remaining unseen bug in the common TTS cache ? No one is complaining in the 4.0. milestone versions, but as it is not implemented in any TTS, the opposite would be surprising !

[lolodomo]

I have no doubt that the common cache has more functionnality than the custom google one. (I didn't look at Polly TTS recently but I think it is nearly the same). I think we should make the shift, on the paper at least.

In case you have time to propose the PR for Polly TTS before the 16th of July, I will take the time to review and merge it.

My last concern is : is there some remaining unseen bug in the common TTS cache ? No one is complaining in the 4.0. milestone versions, but as it is not implemented in any TTS, the opposite would be surprising !

I made tests myself with positive results. I am running the VoiceRSS updated version since several days.

[dalgwen]

In case you have time to propose the PR for Polly TTS before the 16th of July, I will take the time to review and merge it.

#15228
(But I did not manage to test it, so it's a draft.)

[lolodomo]

Now done for all TTS services