Add an edit and remove button when nutriscore prediction is posted on Slack channel #783

Jagrutiti · 2022-06-01T15:59:10Z

What

I have added an edit button, to edit the product information when the nutrition score is posted on the Slack channel.

Fixes bug(s)

Make the Nutri-Score detection prediction actionable ("Delete" button & Thumbnail) #317

Part of

Do not apply nutriscore prediction if it does not match the current nutriscore of the product. #115 , Two different Nutri-Score at the same time #355

alexgarel

👏 well done @Jagrutiti

You only have to lint + change the title of your PR :-)

Lets merge this one and go ahead with next feature !

robotoff/slack.py

robotoff/insights/extraction.py

robotoff/models.py

robotoff/slack.py

tests/unit/test_slack.py

robotoff/models.py

robotoff/slack.py

alexgarel

@Jagrutiti thanks for your work. Still some changes necessary, but we never were so close to the end ;-)

tests/unit/test_slack.py

robotoff/models.py

tests/unit/test_slack.py

Co-authored-by: Alex Garel <alex@garel.org>

…titi/robotoff into robotoff-openfoodfacts#317

…dfacts#317

alexgarel · 2022-06-10T15:29:27Z

tests/unit/test_slack.py

        )
    )

    mock.assert_called_once_with(
        notifier.POST_MESSAGE_URL,
        data=PartialRequestMatcher(
-            f"The `en:vegan` label was automatically added to product 123 (<https://world.{settings._robotoff_domain}/product/123|product>, <{settings.OFF_IMAGE_BASE_URL}/image/1|source image>)",
+            f"The `en:vegan` label was automatically added to product 123 (<https://world.{settings._robotoff_domain}/product/123|product>, <https://robotoff.{settings._robotoff_domain}/api/v1/images/crop?image_url={settings.OFF_IMAGE_BASE_URL}/image/1&y_min=2&x_min=2&y_max=4&x_max=4|source image>)",


This should not change, you restored the test, so there should be non crop any more

codecov · 2022-06-11T08:35:13Z

Codecov Report

Merging #783 (fb98e7a) into master (1e63ca2) will increase coverage by 6.26%.
The diff coverage is 69.09%.

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   44.73%   51.00%   +6.26%     
==========================================
  Files          96       92       -4     
  Lines        6981     6772     -209     
==========================================
+ Hits         3123     3454     +331     
+ Misses       3858     3318     -540

Impacted Files	Coverage Δ
robotoff/cli/batch.py	`0.00% <ø> (ø)`
robotoff/cli/insights.py	`0.00% <0.00%> (ø)`
robotoff/insights/dataclass.py	`100.00% <ø> (ø)`
robotoff/prediction/ocr/brand.py	`68.62% <0.00%> (ø)`
robotoff/prediction/ocr/expiration_date.py	`25.71% <ø> (ø)`
robotoff/prediction/ocr/label.py	`72.30% <0.00%> (ø)`
robotoff/prediction/ocr/product_weight.py	`49.10% <0.00%> (+1.28%)`	⬆️
robotoff/products.py	`41.51% <ø> (+1.02%)`	⬆️
robotoff/workers/listener.py	`0.00% <0.00%> (ø)`
robotoff/metrics.py	`23.61% <10.00%> (-2.20%)`	⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34f786b...fb98e7a. Read the comment docs.

alexgarel · 2022-06-11T08:46:56Z

@Jagrutiti I merged though test didn't pass but, I will fix with another PR (Sonar seems unable to run on an external repository PR). Please, makes your next PRs directly from this repository (not from your own).

Jagrutiti · 2022-06-11T14:58:52Z

Please, makes your next PRs directly from this repository (not from your own).

I will need to remember that.

Added edit button and wrote test case to test the same

67f8f88

github-actions bot assigned Jagrutiti Jun 1, 2022

alexgarel approved these changes Jun 2, 2022

View reviewed changes

robotoff/slack.py Outdated Show resolved Hide resolved

Jagrutiti added 2 commits June 3, 2022 22:13

Getting nutriscore image

f512751

Made new changes to add nutriscore in slack

d72707c

Jagrutiti changed the title ~~Added edit button and wrote test case to test the same~~ Add an edit and remove button when nutriscore prediction is posted on Slack channel Jun 4, 2022

Fixed formatting and styling

0c158a4

Jagrutiti marked this pull request as ready for review June 4, 2022 14:10

Jagrutiti requested a review from a team as a code owner June 4, 2022 14:10

alexgarel reviewed Jun 4, 2022

View reviewed changes

robotoff/insights/extraction.py Show resolved Hide resolved

alexgarel reviewed Jun 4, 2022

View reviewed changes

robotoff/models.py Outdated Show resolved Hide resolved

alexgarel reviewed Jun 4, 2022

View reviewed changes

robotoff/slack.py Outdated Show resolved Hide resolved

alexgarel reviewed Jun 4, 2022

View reviewed changes

tests/unit/test_slack.py Outdated Show resolved Hide resolved

Jagrutiti added 2 commits June 4, 2022 21:14

Updating code based on PR review

ddb236e

calling crop_image_url from module level on slack.py

3d59bec

alexgarel reviewed Jun 6, 2022

View reviewed changes

robotoff/models.py Show resolved Hide resolved

alexgarel reviewed Jun 6, 2022

View reviewed changes

robotoff/slack.py Outdated Show resolved Hide resolved

Jagrutiti added 5 commits June 6, 2022 20:39

Removing duplicate code

568a4c5

fixing failed test cases

f5be0f2

Fixing test cases

85e14ed

Tried fixing failed test cases

6b85b26

Fixing test cases

2ffc53a

alexgarel requested changes Jun 10, 2022

View reviewed changes

tests/unit/test_slack.py Outdated Show resolved Hide resolved

tests/unit/test_slack.py Outdated Show resolved Hide resolved

tests/unit/test_slack.py Outdated Show resolved Hide resolved

robotoff/models.py Show resolved Hide resolved

tests/unit/test_slack.py Outdated Show resolved Hide resolved

Jagrutiti and others added 5 commits June 10, 2022 20:12

Update tests/unit/test_slack.py

4ce0d4a

Co-authored-by: Alex Garel <alex@garel.org>

Update tests/unit/test_slack.py

c6d0744

Co-authored-by: Alex Garel <alex@garel.org>

removing unwanted changes from the test cases

df4e1bc

Merge branch 'robotoff-openfoodfacts#317' of /~https://github.com/Jagru…

c9c6d72

…titi/robotoff into robotoff-openfoodfacts#317

Merge /~https://github.com/openfoodfacts/robotoff into robotoff-openfoo…

43aa3fc

…dfacts#317

alexgarel reviewed Jun 10, 2022

View reviewed changes

Restoring test cases

5073f6a

Jagrutiti and others added 4 commits June 10, 2022 21:12

Formatted the files

fbe5790

fixing test case

649ef35

Fixing test case

529dc8d

fix: fix mypy issues

083af61

alexgarel force-pushed the robotoff-#317 branch from 2452aea to 083af61 Compare June 11, 2022 07:30

fix: fix i18n unbalanced parenthesis

fb98e7a

alexgarel force-pushed the robotoff-#317 branch from 2ce93a6 to fb98e7a Compare June 11, 2022 08:27

alexgarel merged commit 0055ba7 into openfoodfacts:master Jun 11, 2022

alexgarel mentioned this pull request Jun 11, 2022

chore(master): release 1.6.0 #766

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an edit and remove button when nutriscore prediction is posted on Slack channel #783

Add an edit and remove button when nutriscore prediction is posted on Slack channel #783

Jagrutiti commented Jun 1, 2022

alexgarel left a comment

alexgarel left a comment

alexgarel Jun 10, 2022

codecov bot commented Jun 11, 2022

alexgarel commented Jun 11, 2022

Jagrutiti commented Jun 11, 2022

Add an edit and remove button when nutriscore prediction is posted on Slack channel #783

Add an edit and remove button when nutriscore prediction is posted on Slack channel #783

Conversation

Jagrutiti commented Jun 1, 2022

What

Fixes bug(s)

Part of

alexgarel left a comment

Choose a reason for hiding this comment

alexgarel left a comment

Choose a reason for hiding this comment

alexgarel Jun 10, 2022

Choose a reason for hiding this comment

codecov bot commented Jun 11, 2022

Codecov Report

alexgarel commented Jun 11, 2022

Jagrutiti commented Jun 11, 2022