Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshot generation to GitHub Actions pipeline #3477

Open
2 tasks
Tracked by #4167
teolemon opened this issue Aug 25, 2020 · 5 comments
Open
2 tasks
Tracked by #4167

Add screenshot generation to GitHub Actions pipeline #3477

teolemon opened this issue Aug 25, 2020 · 5 comments

Comments

@teolemon
Copy link
Member

teolemon commented Aug 25, 2020

  • Add screenshot generation to GitHub Actions pipeline
  • Upload generated screenshots somewhere (not directly the Play Store, since post-processing and validation is needed, a bucket or the OFF server will do)
          steps:
            - name: Upload generated screenshots as build artefacts
              uses: actions/upload-artifact@v2
              with:
                name: homework
                path: math-homework.txt
@Poussinette
Copy link

Hi! I'd like to work on this issue :)

@Poussinette
Copy link

@teolemon do you know which workflow should generate screenshot? and after which step should we generate screenshot and upload it?

@teolemon
Copy link
Member Author

teolemon commented Oct 9, 2020

hi/salut @Poussinette
here are the screenshots we currently generate: https://photos.app.goo.gl/3KvmivgiXTsbzyMVA

  • History (prepopulated)
  • Scan (populated)
  • Onboarding slides
  • Product page (summary) with a bug on the front photo

Screenshots that would be nice:

  • Adding compare mode screenshot with 2 products side by side
  • Fixing the photo issue in the product page screenshot
  • Search results screenshot

@teolemon
Copy link
Member Author

@Poussinette Also, I think we should have a separation action, that would be triggered only on a specific branch ("generate-screenshots"). Then whenever we want to trigger a new generation, we would merger develop into this branch

@teolemon teolemon linked a pull request Apr 28, 2021 that will close this issue
4 tasks
@teolemon
Copy link
Member Author

teolemon commented May 8, 2021

@Poussinette fyi, I created a draft PR for this, which is not working yet, but seems a good start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants