Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: New translations for Hunger Games #551

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Feat: New translations for Hunger Games #551

merged 1 commit into from
Apr 24, 2023

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@github-actions github-actions bot requested a review from a team as a code owner February 24, 2023 10:58
@github-actions github-actions bot force-pushed the l10n_master branch 7 times, most recently from 3977b96 to 0ffa7a4 Compare March 4, 2023 10:49
@github-actions github-actions bot force-pushed the l10n_master branch 4 times, most recently from d65eab9 to 3606b47 Compare March 8, 2023 11:01
"text2": "Simply answer with a <strong>Yes/No</strong>! Don't know the answer? That's alright, just skip it.",
"text3": "You can also use your keyboard shortcuts: y,n and k.",
"text2": "Отговори просто с <strong>Да/Не</strong>! Не знаеш отговора? Всичко е наред, просто го пропусни.",
"text3": "Можеш също да използваш клавишните комбинации: y,n и k.",
"text4": "Можете да <strong>филтрирате</strong> продуктите въз основа на държава, марки, популярност и много повече!",
"text5": "Ако не искате да правите това всеки път, можете също да <strong>запазите филтрите</strong> като щракнете върху звездата. Следващият път, когато се върнете, намерете запазените филтри на самата начална страница"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @github-actions[bot]. No potential errors found.

@@ -56,6 +56,7 @@
"labels": "Labels",
"brand": "brand",
"brands": "Brands",
"packaging": "packaging",
"quantity": "Quantity",
"insightTypeLabel": "Only shows",
"ingredients": "Ingredients",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @github-actions[bot],

The code changes in this pull request look good to me. Adding the "packaging" translation seems like a necessary addition for a production-ready code. I do not see any potential errors or issues with this change.

Thank you for your contribution to the project!

@@ -56,6 +56,7 @@
"labels": "Labels",
"brand": "brand",
"brands": "Brands",
"packaging": "packaging",
"quantity": "Quantity",
"insightTypeLabel": "Only shows",
"ingredients": "Ingredients",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @github-actions[bot],

The added translation for "packaging" looks good to me. However, I suggest adding a comment explaining the purpose of this change. Also, please make sure to run tests to ensure that this change does not introduce any errors or conflicts with existing code.

Thanks!

@github-actions github-actions bot force-pushed the l10n_master branch 8 times, most recently from 955c607 to c8bb60b Compare March 16, 2023 10:57
@github-actions github-actions bot force-pushed the l10n_master branch 6 times, most recently from 42083a6 to 0126229 Compare March 22, 2023 10:56
@github-actions github-actions bot force-pushed the l10n_master branch 8 times, most recently from 4138d85 to aaadc3b Compare April 7, 2023 10:56
@github-actions github-actions bot force-pushed the l10n_master branch 8 times, most recently from 3c3b68d to 3571b5a Compare April 15, 2023 10:19
@github-actions github-actions bot force-pushed the l10n_master branch 7 times, most recently from 2d57a7f to c8cc6d4 Compare April 22, 2023 10:27
@teolemon teolemon merged commit 99faa4a into master Apr 24, 2023
@teolemon teolemon deleted the l10n_master branch April 24, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants