Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change header color to match new OFF design #366

Merged

Conversation

abhilipsasahoo03
Copy link
Contributor

What

Changed header color to harmonize it with new Open Food Facts design

Screenshot

Screenshot_2022-11-28-00-56-54-024_com android chrome

Fixes bug(s)

Fixes #273

@abhilipsasahoo03
Copy link
Contributor Author

@alexfauquette kindly review!

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/App.js Outdated Show resolved Hide resolved
@abhilipsasahoo03
Copy link
Contributor Author

Hi @alexfauquette I've replied to your comment, kindly review :)

@alexfauquette
Copy link
Member

alexfauquette commented Nov 29, 2022

Maybe it's the correct secondary color, but the top bar should have #f2e9e4 because of

// additional top bar color between latte and cappucino
$cafecreme: #f2e9e4;

I don't know what should be the correct colors, so I let @teolemon have a look

I'm moving the PR to dev branch to trigger netlify deploy

@alexfauquette alexfauquette changed the base branch from master to dev November 29, 2022 11:01
@abhilipsasahoo03
Copy link
Contributor Author

Maybe it's the correct secondary color, but the top bar should have #f2e9e4 because of

// additional top bar color between latte and cappucino
$cafecreme: #f2e9e4;

I don't know what should be the correct colors, so I let @teolemon have a look

I'm moving the PR to dev branch to trigger netlify deploy

Okay no issues @alexfauquette 👍

@abhilipsasahoo03
Copy link
Contributor Author

Hey @alexfauquette @teolemon kindly review and let me know if any change is required?

@VaiTon
Copy link
Member

VaiTon commented Dec 8, 2022

Hey @abhilipsasahoo03! I see that there are a lot of changes not directly related to this fix. If that's the case, please split this PR into two and let's analyze them one by one! Thank you for your work!

@abhilipsasahoo03
Copy link
Contributor Author

abhilipsasahoo03 commented Dec 9, 2022

Hey @abhilipsasahoo03! I see that there are a lot of changes not directly related to this fix. If that's the case, please split this PR into two and let's analyze them one by one! Thank you for your work!

Hi @VaiTon actually all the other changes have not been made by me. They are reflected because the base branch has been pushed from master to dev. You can check the commit history of the PR.

@alexfauquette alexfauquette changed the base branch from dev to master December 9, 2022 10:17
@alexfauquette
Copy link
Member

Yes, and I don't know why it did not trigger the Netlify rendering

By the way, I took some time to check the design resources.

My main concern is the topBar which is now nearly the same color as the background

image

So the minimal to merge the PR would be to add "#f2e9e4" as a background to the AppBar (defined in src/components/ResponsiveAppBar.jsx)


If you want to go further with the setup of the palette, here is the design system

https://www.figma.com/file/Qg9URUyrjHgYmnDHXRsTTB/New-website-design-(2022)-(Quentin)?node-id=0%3A2&t=2kXx3sHDtOs1vdcH-0

And here is the docs of MUI platte

https://mui.com/material-ui/customization/palette/

@abhilipsasahoo03
Copy link
Contributor Author

abhilipsasahoo03 commented Dec 9, 2022

Yes, and I don't know why it did not trigger the Netlify rendering

By the way, I took some time to check the design resources.

My main concern is the topBar which is now nearly the same color as the background

image

So the minimal to merge the PR would be to add "#f2e9e4" as a background to the AppBar (defined in src/components/ResponsiveAppBar.jsx)


If you want to go further with the setup of the palette, here is the design system

https://www.figma.com/file/Qg9URUyrjHgYmnDHXRsTTB/New-website-design-(2022)-(Quentin)?node-id=0%3A2&t=2kXx3sHDtOs1vdcH-0

And here is the docs of MUI platte

https://mui.com/material-ui/customization/palette/

Hey @alexfauquette thank you so much for the resources! I'll definitely change it to #f2e9e4. Btw, do these commits raise a concern? Should I create a new PR instead? Or is it fine to merge it just how it is?

EDIT: I just saw the base branch has been changed back to master 😅

Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>

Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@abhilipsasahoo03
Copy link
Contributor Author

@alexfauquette I've made the change. Kindly check out!

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though you would keep the previous one as a secondary color and only give a special background to the APp bar, but sounds good too

@alexfauquette alexfauquette merged commit eee5a08 into openfoodfacts:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonizing the header color of Hunger Games with the new design
3 participants