-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change header color to match new OFF design #366
fix: change header color to match new OFF design #366
Conversation
Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>
@alexfauquette kindly review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexfauquette I've replied to your comment, kindly review :) |
Maybe it's the correct secondary color, but the top bar should have // additional top bar color between latte and cappucino
$cafecreme: #f2e9e4; I don't know what should be the correct colors, so I let @teolemon have a look I'm moving the PR to |
Okay no issues @alexfauquette 👍 |
Hey @alexfauquette @teolemon kindly review and let me know if any change is required? |
Hey @abhilipsasahoo03! I see that there are a lot of changes not directly related to this fix. If that's the case, please split this PR into two and let's analyze them one by one! Thank you for your work! |
Hi @VaiTon actually all the other changes have not been made by me. They are reflected because the base branch has been pushed from master to dev. You can check the commit history of the PR. |
Yes, and I don't know why it did not trigger the Netlify rendering By the way, I took some time to check the design resources. My main concern is the topBar which is now nearly the same color as the background So the minimal to merge the PR would be to add If you want to go further with the setup of the palette, here is the design system And here is the docs of MUI platte |
Hey @alexfauquette thank you so much for the resources! I'll definitely change it to EDIT: I just saw the base branch has been changed back to master 😅 |
Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com> Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@alexfauquette I've made the change. Kindly check out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though you would keep the previous one as a secondary color and only give a special background to the APp bar, but sounds good too
What
Changed header color to harmonize it with new Open Food Facts design
Screenshot
Fixes bug(s)
Fixes #273