Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unrecognized values of sampler and exporter consistently with … #1317

Closed
wants to merge 1 commit into from
Closed

Handle unrecognized values of sampler and exporter consistently with … #1317

wants to merge 1 commit into from

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Jan 5, 2021

…propagator.

Changes

We only specify what to do with unrecognized values of propagator. Presumably we do the same thing for sampler / exporter.

@anuraaga anuraaga requested review from a team January 5, 2021 05:27
@Oberon00
Copy link
Member

Oberon00 commented Jan 5, 2021

I think we should specify that in general for all environment variables.

@anuraaga
Copy link
Contributor Author

anuraaga commented Jan 6, 2021

@Oberon00 Thanks, makes sense. Since it fit perfectly, I went ahead and merged it into #1316

@anuraaga anuraaga closed this Jan 6, 2021
@anuraaga anuraaga mentioned this pull request Jan 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arminru arminru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuraaga @Oberon00 @arminru