make sure span is recording before setting attributes

open-telemetry · Oct 19, 2024 · 9ac90f9 · 9ac90f9
1 parent bbee109
commit 9ac90f9
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py b/...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
@@ -65,15 +65,17 @@ def traced_method(wrapped, instance, args, kwargs):
                     tool_calls=kwargs.get("tools") is not None,
                 )
             else:
-                _set_response_attributes(span, result)
+                if span.is_recording():
+                    _set_response_attributes(span, result)
                 span.end()
                 return result
 
         except Exception as error:
             span.set_status(Status(StatusCode.ERROR, str(error)))
-            span.set_attribute(
-                ErrorAttributes.ERROR_TYPE, type(error).__qualname__
-            )
+            if span.is_recording():
+                span.set_attribute(
+                    ErrorAttributes.ERROR_TYPE, type(error).__qualname__
+                )
             span.end()
             raise