Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable plugin via environment variable #655

Closed
vmarchaud opened this issue Dec 29, 2019 · 4 comments · Fixed by #1153
Closed

Allow to disable plugin via environment variable #655

vmarchaud opened this issue Dec 29, 2019 · 4 comments · Fixed by #1153
Labels
Discussion Issue or PR that needs/is extended discussion. feature-request

Comments

@vmarchaud
Copy link
Member

When discussing about the unpatch method of each plugin, i said that which make me think that it would be useful to disable plugin but via environemnt variable.

The use cases is pretty simple: modifying the code can take more than 10min for some CI setup (time to rebuild, push images etc) so removing plugins can take quite some times.
Having a environment variable to do that allows engineer to test out quickly by just re-deploying their app.

Datadog actually implemented that recently: DataDog/dd-trace-js#733 so i believe i'm not the only one having this need.

WDYT ?

@vmarchaud vmarchaud added Discussion Issue or PR that needs/is extended discussion. and removed Agreed labels Dec 29, 2019
@dyladan
Copy link
Member

dyladan commented Dec 30, 2019

I think we should wait for the named tracer PR to merge since this is the use case it is designed for

@markwolff
Copy link
Member

markwolff commented Jun 9, 2020

Is this ready to be looked at now? This is something I am interested in as well so I can stub something out if you haven't already @vmarchaud. I also think a separate environment variable to disable all plugins would be useful here.

@vmarchaud
Copy link
Member Author

@markwolff I didnt started any work on that so you can do it if you want to :)

@dyladan
Copy link
Member

dyladan commented Jun 9, 2020

I'd say go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion. feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants