You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@MSNev@obecny and I had a quick call about the diag logger. documenting decisions here for future reference:
Should we keep the log levels or reduce to just console levels?
Error, warn, info, debug, verbose, none/all
Do we want to pass loggers as part of the config of each component?
No. For now, components will call the global logger. This removes the OptionalDiagLogger and the getDiagLoggerFromConfig helpers. The logging global error handler will go to api.diag.error
Do we want to create a base class with setLogger, logger getter helpers? Do we want to have a component namespace for logging a single component?
We are going to leave this for a future enhancement. Existing getters for the logger will be changed to point to the api.diag logger. Other classes which don’t have existing getters will be changed to use api.diag directly at the point of use.
Keep the existing numbering from the existing PR to keep space between log levels to allow additional levels to be added in the future. This will break numeric compatibility with the old logger.
Introduction of new api.diag global logger as discussed during SIG meetings and linked to #1754 and Part 1 #1877
Basic outline
api.diag
with methods likeapi.diag.warn
,api.diag.debug
, etc.Part 2
Will include breaking changes
The text was updated successfully, but these errors were encountered: