-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collector Exporter - split into 3 packages #1429
Comments
@open-telemetry/javascript-approvers ^^ |
Seems like a decent compromise to me. @mayurkale22 ? |
Updated naming for packages ^^ |
FWIW. This is exactly what is being asked for in this specification issue: open-telemetry/opentelemetry-specification#678.
|
Makes sense to me. This would definitely simply the collector codebase and provide an easy way to use it. Couple of questions:
|
Looks like you already answered the first question in the description. My Bad! |
They will be in main package as they are needed there anyway - I have already started working on that :) |
Some people are using for example aws lambda, this means the size of overall matters and there is some limitation in package size. Currently we have grpc and protobufjs installed always. For this reason if someone wants to use the exporter and never want to use grpc or proto he could use an exporter package without grpc and proto. This would means splitting exporter into 3 packages:
collector-exporter-node
collector-exporter-node-proto
collector-exporter-node-grpc
The benefit would be the decrease in size and we would get rid of
protocolNode
param from config.opentelemetry-exporter-collector
would be a main package for web and for node using json over http only.opentelemetry-exporter-collector-proto
would extendopentelemetry-exporter-collector
and override the transport method with proto over httpopentelemetry-exporter-collector-grpc
would extendopentelemetry-exporter-collector
and override the transport method with grpcThe naming for packages
@opentelemetry/exporter-collector
@opentelemetry/exporter-collector-proto
@opentelemetry/exporter-collector-grpc
The text was updated successfully, but these errors were encountered: