-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove component attribute from instrumentations #1399
fix: remove component attribute from instrumentations #1399
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
- Coverage 96.08% 96.06% -0.03%
==========================================
Files 14 14
Lines 895 890 -5
Branches 192 192
==========================================
- Hits 860 855 -5
Misses 35 35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging this I want to double check that there is another way of identifying the document load spans. I don't think there are any semantic conventions specifically for the browser instrumentations (unlike the database one). Users might be relying on the component to be there for these spans.
There is instrumentation scope on each span which identifies the tracer. Each instrumentation has a tracer so this should be an exact replacement |
@Flarna That's a good point. I think it still might break some queries for some users, but this are experimental instrumentations, and as long as there is some way to identify I am 👍 |
…#1399) Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
Which problem is this PR solving?
Short description of the changes