Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove component attribute from instrumentations #1399

Merged
merged 3 commits into from
Feb 19, 2023

Conversation

blumamir
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • remove the "component" attribute from "@opentelemetry/instrumentation-document-load" and "@opentelemetry/instrumentation-long-task" as well as clean up some related dead code in other places

@blumamir blumamir requested a review from a team February 16, 2023 09:33
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1399 (4a6adcf) into main (ee0a59a) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
- Coverage   96.08%   96.06%   -0.03%     
==========================================
  Files          14       14              
  Lines         895      890       -5     
  Branches      192      192              
==========================================
- Hits          860      855       -5     
  Misses         35       35              
Impacted Files Coverage Δ
...entation-document-load/src/enums/AttributeNames.ts 100.00% <ø> (ø)
...strumentation-document-load/src/instrumentation.ts 98.79% <ø> (-0.02%) ⬇️
...y-instrumentation-long-task/src/instrumentation.ts 94.44% <ø> (-0.30%) ⬇️

Copy link
Contributor

@martinkuba martinkuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this I want to double check that there is another way of identifying the document load spans. I don't think there are any semantic conventions specifically for the browser instrumentations (unlike the database one). Users might be relying on the component to be there for these spans.

@Flarna
Copy link
Member

Flarna commented Feb 16, 2023

There is instrumentation scope on each span which identifies the tracer. Each instrumentation has a tracer so this should be an exact replacement

@martinkuba
Copy link
Contributor

@Flarna That's a good point. I think it still might break some queries for some users, but this are experimental instrumentations, and as long as there is some way to identify I am 👍

@haddasbronfman haddasbronfman merged commit e93a192 into open-telemetry:main Feb 19, 2023
@dyladan dyladan mentioned this pull request Feb 19, 2023
Abinet18 pushed a commit to Abinet18/opentelemetry-js-contrib that referenced this pull request Feb 25, 2023
…#1399)

Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants