Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/azuredataexplorer] add workload identity authentication #31736

Closed
wants to merge 19 commits into from

Conversation

Copy link

linux-foundation-easycla bot commented Mar 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@roysha1 roysha1 marked this pull request as ready for review March 13, 2024 20:43
@roysha1 roysha1 requested review from a team and MovieStoreGuy March 13, 2024 20:43
@roysha1
Copy link
Author

roysha1 commented Mar 13, 2024

@asaharn / @ag-ramachandran can you please review?

@ag-ramachandran
Copy link
Contributor

LGTM!

@MovieStoreGuy
Copy link
Contributor

I don't think I have rebased against main so much in a single PR.

@ag-ramachandran
Copy link
Contributor

I don't think I have rebased against main so much in a single PR.

Hello @MovieStoreGuy , Sorry about that. I will have a look at it today as well

@ag-ramachandran
Copy link
Contributor

Hello @MovieStoreGuy , lets hold on for the merge today (10/Apr/2024). There are some changes in the underlying SDK as well. Will try and see if the feature added is compatible with that

@roysha1 : will sync with you on this

@ag-ramachandran
Copy link
Contributor

Hello @MovieStoreGuy , lets hold on for the merge today (10/Apr/2024). There are some changes in the underlying SDK as well. Will try and see if the feature added is compatible with that

@roysha1 : will sync with you on this

Hello @MovieStoreGuy , Looks good to be merged. The only check that is failing is a UT test report upload.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 25, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants