-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/k8sattributes] Use the already available internal docker.ParseImageName function #36418
[processor/k8sattributes] Use the already available internal docker.ParseImageName function #36418
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Pinging code owners for processor/k8sattributes: @dmitryax @fatsheep9146 @TylerHelmuth. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label. |
We could also consider using the https://pkg.go.dev/github.com/distribution/reference#Reference package as it was mentioned at #36145 (comment) by @spiffyy99. (already used at opentelemetry-collector-contrib/processor/k8sattributesprocessor/internal/kube/client.go Line 720 in 97659b5
|
@TylerHelmuth I would like to take on this issue. |
I have made the changes to use the docker.ParseImageName function as well as updated the import name for the The current test that the old method was supporting is failing due to the lack of image digest support: @TylerHelmuth, do you want this PR to stay as a draft PR or mark it as ready with the known test failure? |
I would prefer to all components use the same strategy for common functionalities. Note that the shared function cannot parse images with digest at the moment and should be fixed beforehand: #36279
Originally posted by @rogercoll in #36145 (comment)
The text was updated successfully, but these errors were encountered: