deltatocumulative re-uses memory

[sh0rez]

Component(s)

processor/deltatocumulative

What happened?

The new Linear part of deltatocumulative does not properly clone the first datapoint, instead stores the one from the pmetric.Metrics it receives.

This leads to a racy condition where subsequent aggregations change the emitted result, possibly leading to false outputs.

To fix, change to dp.Clone() here:

opentelemetry-collector-contrib/processor/deltatocumulativeprocessor/linear.go

Line 113 in 2b9ec02

return dp, nil

Collector version

2b9ec02

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[ArthurSens]

This was fixed by #35562, right?

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

[github-actions]

Pinging code owners for processor/deltatocumulative: @sh0rez @RichieSams. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

[crobert-1]

This was fixed by #35562, right?

I believe you're right, fixed by #35562

(@sh0rez please feel free to let us know if this is incorrect)