Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awsemf exporter tests fails if a valid aws configuration is found locally #31010

Closed
codeboten opened this issue Feb 1, 2024 · 7 comments
Closed
Assignees
Labels
closed as inactive exporter/awsemf awsemf exporter good first issue Good for newcomers help wanted Extra attention is needed Stale

Comments

@codeboten
Copy link
Contributor

Component(s)

exporter/awsemf

Describe the issue you're reporting

Running the command make -C exporter/awsemfexporter test to run the unit tests for awsemfexporter fails when a valid configuration is present on the system.

Ideally the tests shouldn't be impacted by the configuration on the local system

@codeboten codeboten added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 1, 2024
@github-actions github-actions bot added the exporter/awsemf awsemf exporter label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@berkeli
Copy link

berkeli commented Feb 3, 2024

Happy to look into this one

@bryan-aguilar
Copy link
Contributor

Thank you @berkeli! Give me a shout if you run into any issues.

@berkeli
Copy link

berkeli commented Feb 7, 2024

Hi @bryan-aguilar could you tell me which config needs to be present for tests to fail?

I've tried with a local otel config file but tests work fine

@bryan-aguilar
Copy link
Contributor

I believe it is a set of valid AWS credentials. Which should be in ~/.aws/. It may honestly be for any set of valid credentials because the go sdk will use it's standard tool chain. https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html#specifying-credentials

Copy link
Contributor

github-actions bot commented Apr 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 8, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive exporter/awsemf awsemf exporter good first issue Good for newcomers help wanted Extra attention is needed Stale
Projects
None yet
Development

No branches or pull requests

3 participants