Skip to content
This repository has been archived by the owner on Feb 8, 2025. It is now read-only.

feat: activate sentry for browser #781

Merged
merged 9 commits into from
Apr 18, 2021
Merged

feat: activate sentry for browser #781

merged 9 commits into from
Apr 18, 2021

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Apr 17, 2021

This implements sentry for browser.
As a lot of our code is in javascript/vue, it's important to follow issues in there.
Sentry provides an implementation for vue, but it's not vue3 ready yet.
Activation of performance monitoring in the browser can be done by settings SENTRY_TRACES_SAMPLE_RATE > 0

  • connect to sentry and vue in javascript
  • pass sentry variables in app.blade.php
  • fix sentry variable (which prevent sentry for working!)
  • build source maps and send them to sentry (this does not affect assets builds)
  • Add a new SENTRY_DEFAULT_PII environment variable to enable Default Personally Identifiable Information feature

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin requested a review from a team as a code owner April 17, 2021 20:29
@asbiin asbiin requested review from djaiss and removed request for a team April 17, 2021 20:29
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.
with sentry we need to be extra careful not to send private and identifiable information so we won't have any privacy problems.

@asbiin
Copy link
Contributor Author

asbiin commented Apr 18, 2021

Awesome.
with sentry we need to be extra careful not to send private and identifiable information so we won't have any privacy problems.

I don't think that's an issue at all. Data on sentry are not available in public access, so I don't see any problem in pushing data there.

@djaiss
Copy link
Member

djaiss commented Apr 18, 2021

I don't think that's an issue at all.

It is, for GDPR reasons. The less personal data travel throughout all the systems, the better. Otherwise it'll be very complicated.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@asbiin
Copy link
Contributor Author

asbiin commented Apr 18, 2021

I don't think that's an issue at all.

It is, for GDPR reasons. The less personal data travel throughout all the systems, the better. Otherwise it'll be very complicated.

The only data sent to sentry are defined in sentry.js file, and are ids (+locale, but I don't think it's sensitive data).

@asbiin asbiin merged commit 66ea257 into main Apr 18, 2021
@asbiin asbiin deleted the 20210417-sentry branch April 18, 2021 20:58
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants