Skip to content
This repository has been archived by the owner on Feb 8, 2025. It is now read-only.

feat: implement Laravel sanctum #670

Merged
merged 3 commits into from
Apr 3, 2021
Merged

feat: implement Laravel sanctum #670

merged 3 commits into from
Apr 3, 2021

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Apr 1, 2021

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin requested a review from a team as a code owner April 1, 2021 18:57
@asbiin asbiin requested review from djaiss and removed request for a team April 1, 2021 18:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

djaiss
djaiss approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

The only question I have: why? For our future API?

@asbiin
Copy link
Contributor Author

asbiin commented Apr 3, 2021

Good job.

The only question I have: why? For our future API?

Thanks.
It's useful for the API, and also for any single page application - see https://laravel.com/docs/8.x/sanctum#how-it-works-spa-authentication

@asbiin asbiin merged commit 00adad8 into main Apr 3, 2021
@asbiin asbiin deleted the 20210314-sanctum branch April 3, 2021 07:52
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaiss djaiss djaiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asbiin @djaiss