This repository has been archived by the owner on Feb 8, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amount must ALWAYS be saved as integer.
In this case,
converted_amount
is also render later usingMoneyHelper::format()
which take the amount as an integer.Notes:
2021_07_13_164157_fix_expense_converted_amount.php
use achange()
which does not work on sqlite (it locks the table!)2020_06_30_211833_create_expenses_table.php
also: it will apply for sqlite, or new installation, which is fine, and the migration will not apply to existing installation, which is fine too (the 2nd migration will fix it)Thanks for contributing.
Please make sure your PR follows those guidelines:
SetupDummyAccount
file, so test accounts are populated automatically with fresh data.