No comment #32
Closed
No comment #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
commented
Nov 18, 2020
src/opamPrinter.ml
Outdated
Comment on lines
805
to
808
| |> split_on_chars [ '\n'; '\r' ] | ||
| |> List.map empty_end | ||
| |> List.filter (fun x -> x != "") | ||
| |> String.concat "\n" |
There was a problem hiding this comment.
It's no worse than the rest of the library does - we'll sort this out with #11's rebase for opam 2.2.
|
ping @kit-ty-kate & @NathanReb for basic test? |
…moves trailing newlines
dra27
reviewed
Dec 17, 2020
|
Does this definitely need to be in 2.1.2, just in terms of getting it released very soon? |
|
No need, no. It can be in next release. |
|
From dev meeting: this change won't go in opam-file-format; it might go either in opam-format itself or in an intermediate library. For dune-release, for now the workaround will simply be to strip comments on line 1 manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
OpamPrinter.FullPos.without_commentsand its associateOpamPrinter.FullPos.write_without_commentthat removes all comments from an opamfile, and trailing newlines.cf. ocaml/opam#4302 (comment)
As it is low-level, It's implemented in
opam-file-format, but it can be easily moved intoopam-format.To rebase after #31 merged