Upgrade and clean up legacy code #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVilka
suggested changes
Nov 3, 2020
| (depends | ||
| (ocaml (>= 4.05)) | ||
| (cppo :build) | ||
| ppx_derivers |
There was a problem hiding this comment.
I think you can remove ppx_derivers safely, since it's unnecessary for the ppxlib-port: ocaml-ppx/ppx_derivers#6
There was a problem hiding this comment.
I sent a separate PR for this then: #244
|
Superseded by #246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up several things:
resultandocaml-migrate-parsetree. Both were unused.ounitto theounit2package-w -9otherwise it would have taken me days to do this). This allowed me to detect several unused code (notably in the tests), variables and open.