Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support flags like --color=always and --color=never #719

Closed
obi1kenobi opened this issue Mar 28, 2024 · 0 comments · Fixed by #721
Closed

Support flags like --color=always and --color=never #719

obi1kenobi opened this issue Mar 28, 2024 · 0 comments · Fixed by #721
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

These flags would override when cargo-semver-checks uses ANSI codes to print colorized output. Both cargo and rustc use these flags, and we should support them too.

Use case came up in obi1kenobi/cargo-semver-checks-action#65
@obi1kenobi obi1kenobi added C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Mar 28, 2024
@obi1kenobi obi1kenobi mentioned this issue Mar 28, 2024
Open
@suaviloquence suaviloquence mentioned this issue Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --color setting to CLI. suaviloquence/cargo-semver-checks
1 participant
@obi1kenobi