Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace version is not supported (regression between 0.17 and 0.18) #370

Closed
skyzh opened this issue Feb 16, 2023 · 2 comments · Fixed by #371
Closed

workspace version is not supported (regression between 0.17 and 0.18) #370

skyzh opened this issue Feb 16, 2023 · 2 comments · Fixed by #371
Labels
C-bug Category: doesn't meet expectations

Comments

@skyzh
Copy link
Contributor

skyzh commented Feb 16, 2023

Steps to reproduce the bug with the above code

It seems that there's a regression between 0.17.1 and 0.18.0 that version in workspace is not supported any more?

Thanks for investigating into this issue!

In our root workspace config,

[workspace.package]
version = "0.13.0"

In the workspace member, we have:

[package]
name = "sqllogictest"
version = { workspace = true }

Actual Behaviour

cargo install cargo-semver-checks --version ^0.18 --locked
git clone /~https://github.com/risinglightdb/sqllogictest-rs && cd sqllogictest-rs
cargo semver-checks check-release -p sqllogictest
    Updating index
Error: Failed to retrieve package version from /Users/skyzh/Work/sqllogictest-rs/sqllogictest/Cargo.toml: value from workspace hasn't been set

Expected Behaviour

cargo install cargo-semver-checks --version ^0.17 --locked
git clone /~https://github.com/risinglightdb/sqllogictest-rs && cd sqllogictest-rs
cargo semver-checks check-release -p sqllogictest
    Updating index
     Parsing sqllogictest v0.13.0 (current)
     Parsing sqllogictest v0.13.0 (baseline)
    Checking sqllogictest v0.13.0 -> v0.13.0 (no change)
   Completed [   2.507s] 40 checks; 40 passed, 0 unnecessary

Generated System Information

Software version

cargo-semver-checks 0.18.0

Operating system

macOS 13.1 (Darwin 22.2.0)

Command-line

/Users/skyzh/.cargo/bin/cargo-semver-checks semver-checks --bugreport

cargo version

> cargo -V
cargo 1.67.1 (8ecd4f20a 2023-01-10)

Compile time information

  • Profile: release
  • Target triple: aarch64-apple-darwin
  • Family: unix
  • OS: macos
  • Architecture: aarch64
  • Pointer width: 64
  • Endian: little
  • CPU features: aes,crc,dit,dotprod,dpb,dpb2,fcma,fhm,flagm,fp16,frintts,jsconv,lor,lse,neon,paca,pacg,pan,pmuv3,ras,rcpc,rcpc2,rdm,sb,sha2,sha3,ssbs,vh
  • Host: aarch64-apple-darwin

Build Configuration

No response

Additional Context

No response

@skyzh skyzh added the C-bug Category: doesn't meet expectations label Feb 16, 2023
@skyzh
Copy link
Contributor Author

skyzh commented Feb 16, 2023

fix on the way...

@skyzh
Copy link
Contributor Author

skyzh commented Feb 16, 2023

fixed in #371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: doesn't meet expectations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant