-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Chmod event to Metadata #112
Comments
I like the idea. But adding another variant to |
Is deprecating the |
Yes. The chmod event is always about file metadata, and never limited to just permissions, so that's a good idea. This is both applicable to Chmod (in DebouncedEvent) and CHMOD (in Op). I think we should mark those as deprecated and mention that they'll be renamed. Then the actual change should be done whenever the next major goes through. That might be a while, though. |
Err. Hmm. No, I don't think I've done this. The spec in #117 is basically where I wanted to go, with the current release as a "final 4.x version". As in, I could deprecate this particular thing, but if the API is going to radically change anyway... 🤷 Unfortunately I've mostly lost interest in this project, and that plus being very busy at work and elsewhere has my attention gone. So notify is in a holding pattern of "it works." |
This is done in v5, which also brings a different approach to event classification. |
When you
touch
a file, it currently files the chmod, which sounds incorrect (chmod is about permissions on *nix).An alias to metadata would help code read a little better
The text was updated successfully, but these errors were encountered: