Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added dgram benchmark test #16113

Closed
wants to merge 1 commit into from
Closed

test: added dgram benchmark test #16113

wants to merge 1 commit into from

Conversation

jopann
Copy link
Contributor

@jopann jopann commented Oct 9, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 9, 2017
@jopann
Copy link
Contributor Author

jopann commented Oct 9, 2017

This was a second contribution suggestion from Node.js interactive conf

@mscdex mscdex added dgram Issues and PRs related to the dgram subsystem / UDP. benchmark Issues and PRs related to the benchmark subsystem. labels Oct 10, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10654/

Trott
Trott requested changes Oct 12, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More settings should be passed to reduce the number of benchmarks each file runs to one. So type=send, num=1, len=1, and probably others...

@apapirovski
Copy link
Member

Hi @jopann, would you like to follow up on this and make the changes requested by @Trott? Thanks!

@apapirovski
Copy link
Member

Closing this as there hasn't been any movement on it in a while but feel free to re-open if you would like to continue work on this, @jopann.

@apapirovski apapirovski closed this Dec 2, 2017
@Trott Trott mentioned this pull request Dec 5, 2017
Closed
3 tasks
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott requested changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jopann @joyeecheung @apapirovski @jasnell @Trott @mscdex @nodejs-github-bot